Skip to content

Conversation

@OluwatobiAwe
Copy link
Collaborator

JIRA link

https://hee-dls.atlassian.net/browse/DLSV2-675

Description

When Competency description is blank, then expanders are not appearing as expected but when Competency Description has spaces “ “ in it, expanders are appearing

Screenshots

Attach screenshots on mobile, tablet and desktop.
Competency1
Competency2


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@kevwhitt-hee kevwhitt-hee merged commit 4dcc015 into master Oct 4, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/DLSV2-675-blank-competency-and-competency-group-descriptions-are-being-stored-as-empty-strings-instead-of-null-values branch October 4, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants