Skip to content

Conversation

@martinfoster-hee
Copy link
Contributor

JIRA link

https://hee-dls.atlassian.net/jira/software/projects/DLSV2/boards/1?assignee=6321797ece3e476e42ac8a00&selectedIssue=DLSV2-616

Description

I’ve updated the code so that Rejected items are excluded from the Confirmed count.
The ‘Request Educator/Manager Sign-off’ button is also now not available if one or more items are flagged as ‘Rejected’.

Screenshots

See below.


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

localhost_44363_LearningPortal_SelfAssessment_4_Proficiencies (1)

@kevwhitt-hee kevwhitt-hee merged commit 3e12fa3 into master Oct 7, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/DLSV2-616-AddingLearnerFilterEnablesRequestSignOff branch October 7, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants