Skip to content

Conversation

@martinfoster-hee
Copy link
Contributor

JIRA link

https://hee-dls.atlassian.net/jira/software/projects/DLSV2/boards/1?assignee=6321797ece3e476e42ac8a00&selectedIssue=DLSV2-641

Description

Fixed issue where framework edit pages were failing due to new typefilter.

Screenshots

Screenshot attached.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@martinfoster-hee martinfoster-hee marked this pull request as ready for review October 14, 2022 09:50
@kevwhitt-hee kevwhitt-hee merged commit ca9191c into master Oct 14, 2022
@kevwhitt-hee
Copy link
Contributor

That fix seemed delightfully simple. Let's hope it gets through test this time!

@kevwhitt-hee kevwhitt-hee deleted the (Develop/Fixes/DLSV2-641-NewFrameworkSummaryPageBrowserBack404-4 branch October 14, 2022 13:16
@martinfoster-hee
Copy link
Contributor Author

I hope so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants