Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Oct 14, 2022

JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-659

Description
Skipped adding framework competency to the competency group when it is null.

Screenshots
A screenshot is attached to the Jira ticket.

Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with [Wave Chrome plugin]
  • Updated/added documentation.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@Auldrin-Possa Auldrin-Possa merged commit ea645c3 into master Oct 14, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-659 branch March 22, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant