Develop/fixes/dlsv2 687 page 500 error on choose working group members screen when given user email not associated with dls account #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I decided not to use the view Component specifically created for displaying error such as this because the field doesn't belong to a strongly typed model where error messages and validation messages could be added. |
kevwhitt-hee
requested changes
Oct 17, 2022
| } | ||
| @if (Model.Error) | ||
| { | ||
| @*<vc:error-summary order-of-property-names="@(new string[] { "userEmail" })" />*@ |
There was a problem hiding this comment.
We should be using the error summary view component here. It contains all of the markup included by hand below.
| else if (collaboratorId == -4) | ||
| { | ||
| TempData["FrameworkError"] = $"The email address {userEmail} must match registered DLS Admin account"; | ||
| TempData["FrameworkError"] = $"The email address must match registered DLS Admin account"; |
There was a problem hiding this comment.
Tweak to wording:
"The email address must match registered a DLS Admin account"
| else if (collaboratorId == -2) | ||
| { | ||
| TempData["FrameworkError"] = $"User with the email address {userEmail} has been previously added"; | ||
| TempData["FrameworkError"] = $"User with the email address has been previously added"; |
There was a problem hiding this comment.
Tweak to wording:
"A user with the email address has been previously added"
kevwhitt-hee
approved these changes
Oct 18, 2022
kevwhitt-hee
deleted the
Develop/Fixes/DLSV2-687-page-500-error-on-choose-working-group-members-screen-when-given-user-email-not-associated-with-dls-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
DLSV2-687
Description
Error not properly displayed to conform with all other error across the system.
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: