Skip to content

DLSV2-703 Search result count check implemented prior to display result. #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

DLSV2-703 Search result count check implemented prior to display result. #1432

merged 1 commit into from
Oct 18, 2022

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Oct 17, 2022 •
edited by kevwhitt-hee
Loading

JIRA link
DLSV2-703

Description
Search result count checks are implemented prior to displaying results.

Screenshots
image

Developer checks
I have:

  • Run the formatter and made sure there are no IDE error.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with [Wave Chrome plugin]
  • Updated/added documentation in [Confluence]
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@kevwhitt-hee kevwhitt-hee changed the title Search result count check implemented prior to display result. DLSV2-703 Search result count check implemented prior to display result. Oct 18, 2022
kevwhitt-hee
kevwhitt-hee approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevwhitt-hee kevwhitt-hee merged commit f751371 into master Oct 18, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/fixes/dlsv2-703 branch October 18, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevwhitt-hee kevwhitt-hee kevwhitt-hee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Auldrin-Possa @kevwhitt-hee