Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Oct 19, 2022

JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-695

Description
DataAnnotation added to model property 'DelegateEmails'. Code modified to handle email validation.

Screenshots
image

image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with [Wave Chrome plugin]any valid accessibility issues
  • Updated/added documentation in [Confluence]
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@kevwhitt-hee kevwhitt-hee merged commit 2dd95e7 into master Oct 24, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/fixes/dlsv2-695 branch October 24, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants