Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Nov 2, 2022

JIRA link
https://hee-tis.atlassian.net/browse/TD-570

Description
The attribute route is modified to work when frameworkgroupId is null. SQL query updated to retrieve ungrouped competencies.

Screenshots
N/A

Developer checks
I have:

  • Run the formatter and made sure there are no IDE errors
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with [Wave Chrome plugin] -- Issues not related to this code change.
  • Updated/added documentation in [Confluence]
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@kevwhitt-hee kevwhitt-hee merged commit 86c032a into master Nov 4, 2022
@kevwhitt-hee kevwhitt-hee deleted the HEEDLS-570-Preview-resulted-in-error branch November 4, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants