TD-92 Accessibility screen reader text to differentiate buttons with same name #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwhitt-hee
approved these changes
Nov 8, 2022
kevwhitt-hee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-tis.atlassian.net/browse/TD-92
Description
Dynamic framework name, competency name/group name assigned to hidden span.
Screenshots
Developer checks
I have:
[x] Run the formatter and made sure there are no IDE errors
[ ] Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
[x] Manually tested my work with and without JavaScript
[x] Tested any Views or partials created or changed with [Wave Chrome plugin]
[ ] Updated/added documentation in [Confluence]
[ ] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
[] Scanned over my own MR to ensure everything is as expected and it looks right in the browser