Skip to content

Conversation

@OluwatobiAwe
Copy link
Collaborator

JIRA link

TD-684

Description

Issue with the length of the input boxes on the 'Change password' screen in 'Mobile view'.

Screenshots

MOBILEView


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@OluwatobiAwe
Copy link
Collaborator Author

The update has been initially merged and there would be no code changes; The PR simply corrects a commit error on my part

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any changes to merge here, Oluwatobi?

@kevwhitt-hee kevwhitt-hee changed the title Develop/fixes/td 684 issue with the length of the input boxes on the change password view TD-684 issue with the length of the input boxes on the change password view Nov 11, 2022
@kevwhitt-hee
Copy link
Contributor

These changes look safe to me. I will merge them and pass them over for testing.

@kevwhitt-hee kevwhitt-hee merged commit 164317a into master Nov 11, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-684-issue-with-the-length-of-the-input-boxes-on-the-change-password-view branch November 11, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants