Skip to content

Conversation

@martinfoster-hee
Copy link
Contributor

@martinfoster-hee martinfoster-hee commented Nov 22, 2022

JIRA link

https://hee-tis.atlassian.net/jira/software/c/projects/TD/boards/165?modal=detail&selectedIssue=TD-623&assignee=6321797ece3e476e42ac8a00

Description

Fixed 'Self-assessed (confirmation not yet requested)' filter.
Also various mobile inconsistencies on supervisor views.

Screenshots

Screenshots attached.


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

localhost_44363_LearningPortal_SelfAssessment_4_Proficiencies_Filtered

Capture

Capture2

@martinfoster-hee martinfoster-hee marked this pull request as ready for review November 22, 2022 17:19
@OluwatobiAwe OluwatobiAwe self-requested a review November 23, 2022 07:47
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in code and when built and run in dev.

@kevwhitt-hee kevwhitt-hee merged commit e2ed515 into master Nov 23, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-623-LearnerRequestSignOffIssue branch November 23, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants