Skip to content

Conversation

@martinfoster-hee
Copy link
Contributor

@martinfoster-hee martinfoster-hee commented Nov 30, 2022

JIRA link

https://hee-tis.atlassian.net/jira/software/c/projects/TD/boards/165?modal=detail&selectedIssue=TD-707

Description

Updated Delegate Courses view to show left border colour for Archived and Inactive courses.
Also added Tag ui elements for Archived courses.
Please note that this page now returns archived courses in its results panel.

Screenshots

Screenshots below.


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Updated 'Active' status:
td797_active

Updated 'Inactive/archived'
td797_inactivearchvied

@martinfoster-hee martinfoster-hee marked this pull request as ready for review November 30, 2022 16:46
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and work well when built. Having reviewed the built application, though, I think we need to tweak the status filter slightly:

  • Applying an 'Active' filter should display only active courses that have not been archived.
  • Applying an 'Inactive' filter should display courses that are inactive or archived.
  • We should rename the 'Inactive' filter option as 'Inactive/archived'.

@kevwhitt-hee
Copy link
Contributor

@martinfoster-hee just a nudge to remind you of the requested changes on this one.

@martinfoster-hee
Copy link
Contributor Author

Updated filters are requested.

@kevwhitt-hee kevwhitt-hee merged commit b8e54d2 into master Dec 16, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-707_DelegateCoursesArchivedUIElements branch December 16, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants