-
Notifications
You must be signed in to change notification settings - Fork 1
Develop/Fixes/TD-707_DelegateCoursesArchivedUIElements #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kevwhitt-hee
merged 11 commits into
master
from
Develop/Fixes/TD-707_DelegateCoursesArchivedUIElements
Dec 16, 2022
Merged
Develop/Fixes/TD-707_DelegateCoursesArchivedUIElements #1493
kevwhitt-hee
merged 11 commits into
master
from
Develop/Fixes/TD-707_DelegateCoursesArchivedUIElements
Dec 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwhitt-hee
requested changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and work well when built. Having reviewed the built application, though, I think we need to tweak the status filter slightly:
- Applying an 'Active' filter should display only active courses that have not been archived.
- Applying an 'Inactive' filter should display courses that are inactive or archived.
- We should rename the 'Inactive' filter option as 'Inactive/archived'.
|
@martinfoster-hee just a nudge to remind you of the requested changes on this one. |
|
Updated filters are requested. |
kevwhitt-hee
approved these changes
Dec 16, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-tis.atlassian.net/jira/software/c/projects/TD/boards/165?modal=detail&selectedIssue=TD-707
Description
Updated Delegate Courses view to show left border colour for Archived and Inactive courses.
Also added Tag ui elements for Archived courses.
Please note that this page now returns archived courses in its results panel.
Screenshots
Screenshots below.
Developer checks
I have:
Updated 'Active' status:

Updated 'Inactive/archived'
