Develop/fixes/td 710 display the name of the framework and framework specific vocabulary #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0-display-the-name-of-the-framework-and-framework-specific-vocabulary
kevwhitt-hee
requested changes
Dec 8, 2022
| <li class="nhsuk-breadcrumb__item"><a class="nhsuk-breadcrumb__link trigger-loader" asp-action="ViewFrameworks" asp-route-tabname="Mine">Frameworks</a></li> | ||
| <li class="nhsuk-breadcrumb__item"><a class="nhsuk-breadcrumb__link trigger-loader" asp-action="ViewFramework" asp-route-frameworkCompetencyGroupId="@Model.FrameworkCompetencyGroupId" asp-fragment="fc-@Model.FrameworkCompetency.Id" asp-route-frameworkId="@Model.DetailFramework.ID" asp-route-tabname="Structure">Framework Structure</a></li> | ||
| <li class="nhsuk-breadcrumb__item">Competency</li> | ||
| <li class="nhsuk-breadcrumb__item">@Model.VocabSingular()</li> |
There was a problem hiding this comment.
This framework vocab needs introducing to the new Views/Frameworks/Developer/SimilarCompetency.cshtml ViewModel so that it can be used to replace the word "competency" in the h1 <h1>Duplicate competency name</h1> in the error message has the same name as an existing competency.
There was a problem hiding this comment.
This has been updated.
kevwhitt-hee
approved these changes
Dec 12, 2022
kevwhitt-hee
deleted the
Develop/Fixes/TD-710-display-the-name-of-the-framework-and-framework-specific-vocabulary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
TD-710
Description
Addition of Framework name to list of similar competencies.
The use of framework vocabulary in place of the default competency keyword.
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: