Skip to content

Conversation

@kevwhitt-hee
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee commented Feb 9, 2023

JIRA link

TD-1106

Description

We added code to prevent supervisors from adding themselves as a member of staff (same email address validation). This reverts that change (leaving code in comments to allow easy reinstatement).

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they aren't appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@kevwhitt-hee kevwhitt-hee merged commit b74c1b2 into master Feb 9, 2023
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/TD-1106-RevertPreventSupervisorAddingSelf branch February 9, 2023 14:18
kevwhitt-hee added a commit that referenced this pull request Mar 7, 2023
…s/TD-1106-RevertPreventSupervisorAddingSelf

TD-1106 Allow supervisor self enrolment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant