Skip to content

TD-4502 Issue not listing the delegates on 'Send welcome message' screen for whose Password is set and unclaimed #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Release 2024.38
merged 2 commits into from
Aug 21, 2024
Merged

TD-4502 Issue not listing the delegates on 'Send welcome message' screen for whose Password is set and unclaimed #2776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddb931e
TD-4502 Issue not listing the delegates on 'Send welcome message' scr…
sherif-olaboye Aug 13, 2024
e8417c9
TD-4502 Removing password check from the where condition
sherif-olaboye Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DigitalLearningSolutions.Web/Services/UserService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ public void UpdateFailedLoginCount(UserAccount userAccount)
public IEnumerable<DelegateUserCard> GetDelegateUserCardsForWelcomeEmail(int centreId)
{
return userDataService.GetDelegateUserCardsByCentreId(centreId).Where(
user => user.Approved && !user.SelfReg && string.IsNullOrEmpty(user.Password) &&
user => user.Approved && !user.SelfReg &&
!string.IsNullOrEmpty(user.EmailAddress)
&& !Guid.TryParse(user.EmailAddress, out _)
&& user.RegistrationConfirmationHash != null
Expand Down