Skip to content

Conversation

@rshrirohit
Copy link
Collaborator

@rshrirohit rshrirohit commented Sep 26, 2024

JIRA link

TD-4774

Description

  1. Changed the top set of buttons' location above the search bar
  2. Added warning callout
  3. Removed the above text from the bottom of the page.
  4. Used vocab for correct term

Screenshots

image

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@rshrirohit rshrirohit marked this pull request as ready for review September 26, 2024 15:44
kevwhitt-hee
kevwhitt-hee previously approved these changes Sep 27, 2024
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice and changes look good

@kevwhitt-hee kevwhitt-hee dismissed their stale review September 27, 2024 09:04

missed possible problem during review

@kevwhitt-hee kevwhitt-hee self-requested a review September 27, 2024 09:04
@rshrirohit rshrirohit merged commit a498a5c into Release-2024.38 Oct 8, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-4774-UIChangesOnProficienciesPage branch October 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants