Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Sep 27, 2024

JIRA link

4760

Description

corrected the spelling for assessments in the delegates activity page within the tracking system module

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@ABSinhaa ABSinhaa marked this pull request as ready for review September 27, 2024 16:05
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Should we correct partial view name too @rshrirohit?

… in it's name, checked for reference, found only in Index.cshtml for the tracking system component.
@ABSinhaa
Copy link
Contributor Author

ABSinhaa commented Oct 1, 2024

Hi, @rshrirohit and @Auldrin-Possa
I have corrected the wrongly spelled word in the partial view of the file, It is only being referenced in the the index.cshtml file for Tracking System, only one reference.
Screenshot below :
image

We need to make sure that this module gets tested properly.
Thanks.

@rshrirohit rshrirohit changed the title TD-4760- Corrected the spelling for assessment on the delegates activ… TD-4760- Corrected the spelling for assessment on the delegates activity page. Oct 2, 2024
@rshrirohit rshrirohit merged commit e71f6a0 into Release-2024.38 Oct 2, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-4760-Incorrect-Spelling-Delegate branch October 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants