Skip to content

TD-4469 fix date range labels on summary report #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Release 2024.38
merged 2 commits into from
Oct 8, 2024
Merged

TD-4469 fix date range labels on summary report #2873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60f1ac6
Fixes labelling of date range on last line of summary report
kevwhitt-hee Oct 7, 2024
5acb15d
Fixes test by providing correct end date for expected result
kevwhitt-hee Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DigitalLearningSolutions.Web.Tests/Services/ActivityServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ public void GetActivityDataFileForCentre_returns_expected_excel_data()

var filterData = new ActivityFilterData(
DateTime.Parse("2020-9-1"),
DateTime.Parse("2021-9-1"),
DateTime.Parse("2021-9-30"),
null,
null,
null,
Expand Down
2 changes: 1 addition & 1 deletion DigitalLearningSolutions.Web/Services/ActivityService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public byte[] GetActivityDataFileForCentre(int centreId, ActivityFilterData filt
last.DateInformation.GetDateRangeLabel(
DateHelper.StandardDateFormat,
filterData.EndDate ?? clockUtility.UtcNow,
true
false
),
last.Enrolments,
last.Completions,
Expand Down
Loading