Skip to content

Conversation

@Auldrin-Possa
Copy link
Collaborator

JIRA link

TD-4888

Description

  1. Limiting the supervisors while adding new supervisor, is working as expected. No code change required.
  2. Removed unused parameter 'centreId' from the service method

Screenshots

Tested for 'uat.dlstester3@gmail.com' supervisor for a self-assessment of 'Nursing proficiency passports' category.

  1. When 'auldrin.possa@hee.nhs.uk' supervisor with 'All' or 'Nursing proficiency passports' category.

image

  1. When 'auldrin.possa@hee.nhs.uk' supervisor with 'Digital Workplace' category.

image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review October 30, 2024 14:23
@rshrirohit rshrirohit merged commit 7744ebf into DLS-Release-v1.1.0 Oct 31, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/feature/TD-4888-Limit-supervisors-AddNewSupervisor branch October 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants