Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-4973

Description

I modified the GetResultReviewSupervisorsForSelfAssessmentId query to limit the list of supervisors available for selection to only show supervisors/nominated supervisors who have a category that matches the self assessment (or supervisors/nominated supervisors who are not limited to a category)

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…irmation view to supervisors with a matching category
@rshrirohit rshrirohit merged commit 9c78d1b into DLS-Release-v1.1.0 Nov 6, 2024
2 checks passed
@rshrirohit rshrirohit deleted the Develop/Features/TD-4973-LimitthelistofsupervisorsintheRequestproficiencyconfirmationviewtosupervisorswithamatchingcategory branch November 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants