Skip to content

Conversation

@ABSinhaa
Copy link
Contributor

@ABSinhaa ABSinhaa commented Dec 3, 2024

Limiting the self assessment shown in the manage delegate section.

JIRA link

TD-5026

Description

Added a query check based on the admin categoryID of the logged in user to show the self assessments that match with the specific categoryId for the delegate user in their manage delegate section.

Screenshots


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@ABSinhaa ABSinhaa marked this pull request as ready for review December 3, 2024 16:10
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kevwhitt-hee kevwhitt-hee merged commit 4b0e1f9 into DLS-Release-v1.1.1 Dec 6, 2024
3 checks passed
@kevwhitt-hee kevwhitt-hee deleted the Develop/fixes/TD-5026-Limit_Self_Assessments_Manage_Delegates branch December 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants