Skip to content

Conversation

@sherif-olaboye
Copy link
Contributor

JIRA link

https://hee-tis.atlassian.net/browse/TD-5542

Description

I resolved a validation UI issue where the clickable error summary wasn't scrolling to the correct form field due to mismatched id attributes. Changing the field name from competency-group-name to Name ensures the error summary link now correctly targets the form field, since the generated id now matches.

I also removed SearchableName from ModelState because it's not required, and it is not necessary to show on validation errors or interfere with model binding.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet, and desktop, wave analyser showing no errors.
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@rshrirohit rshrirohit merged commit e9a8a13 into DLS-Release-v1.3.0 May 8, 2025
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fixes/TD-5542-Issuenotfocussingtotherespectivefieldswhenclickedtheerrorlinksontheframeworkssection branch May 8, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants