Heedls 468 basic centre ranking page #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Few minor comments, but I am only halfway through a review before needing to leave for a long weekend. Submitting this review for now in case you want to tackle anything, but anyone else can review it instead if we want to get this ticket out of the way while I'm gone. Otherwise I'll pick it back up first thing on Tuesday.
| </thead> | ||
| <tbody class="nhsuk-table__body"> | ||
| @foreach (var centre in Model.TopTenCentres) { | ||
| <tr role="row" class="nhsuk-table__row @(centre.Rank == Model.CurrentCentre?.Rank ? "current-centre" : string.Empty)"> |
There was a problem hiding this comment.
When I've encountered elements that sometimes need classes and sometimes don't, I've defined a variable at the top of the html in its own code block, rather than in the element attribute itself.
It is by no means a big deal, but do we have a preference one way or the other?
DigitalLearningSolutions.Web/ViewModels/TrackingSystem/Centre/Ranking/CentreRankingViewModel.cs
Outdated
Show resolved
Hide resolved
...lLearningSolutions.Web.Tests/ViewModels/TrackingSystem/Centre/CentreRankingViewModelTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 25, 2021
DigitalLearningSolutions.Web/Views/TrackingSystem/Shared/_NavMenuItems.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Centre/Ranking/_RankingSuperAdminTable.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Centre/Ranking/_RankingSuperAdminTable.cshtml
Outdated
Show resolved
Hide resolved
...alLearningSolutions.Web/Views/TrackingSystem/Centre/Ranking/_RankingStandardUserTable.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Centre/Ranking/_RankingSuperAdminTable.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jun 28, 2021
DigitalLearningSolutions.Web/ViewModels/TrackingSystem/Centre/Ranking/CentreRankViewModel.cs
Outdated
Show resolved
Hide resolved
...Solutions.Web.Tests/ViewModels/TrackingSystem/Centre/DashboardCentreDetailsViewModelTests.cs
Show resolved
Hide resolved
...lLearningSolutions.Web.Tests/ViewModels/TrackingSystem/Centre/CentreRankingViewModelTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/CentresServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/CentresServiceTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new Centre ranking page in the tracking system and the centre rank to the dashboard.
Current centre highlight is the colour chosen by Kevin, but can easily be updated if we need to change it in the future.
Normal admin page:
Super admin version showing the no data for your centre entry - this will always be true for test centre ID 101:
Mobile 3 col layout:
Centre dashboard with no activity. This displays the rank number if there has been activity at the centre in the last 14 days:
