-
Notifications
You must be signed in to change notification settings - Fork 1
Heedls 467 centre contract details #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes.
DigitalLearningSolutions.Web/Views/TrackingSystem/Centre/ContractDetails/Index.cshtml
Outdated
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/Centre/ContractDetails/ContractDetailsViewModel.cs
Outdated
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/Centre/ContractDetails/ContractDetailsViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web.Tests/Helpers/DisplayStringHelperTests.cs
Outdated
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/Centre/ContractDetails/ContractDetailsViewModel.cs
Outdated
Show resolved
Hide resolved
...Solutions.Web/Controllers/TrackingSystem/Centre/ContractDetails/ContractDetailsController.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could do with an extra space, no need for rereview from me though.
...ngSolutions.Web/ViewModels/TrackingSystem/Centre/ContractDetails/ContractDetailsViewModel.cs
Outdated
Show resolved
Hide resolved
...earningSolutions.Web/Views/TrackingSystem/Centre/ContractDetails/_ContractDetailsList.cshtml
Show resolved
Hide resolved
...earningSolutions.Web/Views/TrackingSystem/Centre/ContractDetails/_ContractDetailsList.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Centre/ContractDetails/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Centre/ContractDetails/Index.cshtml
Outdated
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/Centre/ContractDetails/ContractDetailsViewModel.cs
Outdated
Show resolved
Hide resolved
...Solutions.Web/Controllers/TrackingSystem/Centre/ContractDetails/ContractDetailsController.cs
Outdated
Show resolved
Hide resolved
...Solutions.Web/Controllers/TrackingSystem/Centre/ContractDetails/ContractDetailsController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web.Tests/Helpers/DisplayStringHelperTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about handling negative bytes, which we should change & test. No need for rereview though 👍
Added the contract details page