HEEDLS-525 Refactor my account views to fix inconsistent spacing #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveJacksonSoft
suggested changes
Jun 23, 2021
DigitalLearningSolutions.Web/Views/MyAccount/EditDetails.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/NotificationPreferences/UpdateNotificationPreferences.cshtml
Show resolved
Hide resolved
SteveJacksonSoft
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the html in the my account edit details screen and the 2 manage notification screens to fix the spacing before the back links. I've changed the html in the update notification preferences relatively significantly as VS was complaining about invalid html (legend inside div). This means that the page does look a bit different to before, but it now looks more like the rest of the pages in the system.
All the automated accessibility tests still pass + checked with chrome lighthouse for 100 rating on accessibility on the update notification page.