HEEDLS-415 Fix path so it works with site hosted in subdirectory #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellake
reviewed
Jun 24, 2021
|
|
||
| private static getPathForEndpoint(endpoint: string): string { | ||
| const currentPath = window.location.pathname; | ||
| const baseUrlParts = endpoint.split('/'); |
There was a problem hiding this comment.
I thought the 'endpoint' (route) was a relative path (I feel like baseUrlParts can be a misleading name)?
| const baseUrlParts = endpoint.split('/'); | ||
| const indexOfBaseUrl = currentPath.indexOf(baseUrlParts[1]); | ||
| const path = `${currentPath.substring(0, indexOfBaseUrl)}${endpoint}`; | ||
| return path.replace('//', '/'); |
There was a problem hiding this comment.
Could we have the endpoint without "/" in the beginning to avoid skipping the first element when we split the endpoint and to avoid this replace here? Also, could we make sure it's documented that the endpoints would have to be on the same sub-directory after the base url in config for search to work? (e.g. /dev-prev/GenericItems would not work with '/AllGenericItems' as endpoint on UAT, /TrackingSystem can't call /LearningPortal etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back a method to figure out an endpoint from the specified endpoint so that it works with the site hosted in a subdirectory.