Skip to content

HEEDLS-526 Admin Registration frontend and flow #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 29, 2021
Merged

HEEDLS-526 Admin Registration frontend and flow #448

merged 24 commits into from
Jun 29, 2021

Conversation

@ibrahimmunir14
Copy link
Contributor

@ibrahimmunir14 ibrahimmunir14 commented Jun 23, 2021 •
edited
Loading

First page
image

Incorrect email error
image

Learner Information page
image

Password page (same as normal registration)
image

Summary page
image

Confirmation page
image

@ibrahimmunir14
HEEDLS-526 Create RegistrationData; make DelegateRegistrationData a s…
95ce7af 
…ubclass; add and update helper methods and tests
@ibrahimmunir14
HEEDLS-526 Create RegisterAdminController with Index and PersonalInfo…
2bc90bb 
…; create PersonalInfo page
@ibrahimmunir14
HEEDLS-526 Add RegisterAdmin LearnerInformation page
951ad67
@ibrahimmunir14
HEEDLS-526 Add RegisterAdmin Password page
433a9a5
@ibrahimmunir14
HEEDLS-526 Add RegisterAdmin Summary page
fe1f412
@ibrahimmunir14
HEEDLS-526 Add RegisterAdmin Confirmation page
d592330
@ibrahimmunir14
HEEDLS-526 Add method to get AutoRegister values to CentreDataService…
a36387c 
…; add test
@ibrahimmunir14
HEEDLS-526 Check if admin register is allowed for centre on Index GET…
c6022f9 
…; write tests
@ibrahimmunir14
HEEDLS-526 Add admin email address validation on PersonalInformation …
2e9405b 
…page; write tests
@ibrahimmunir14
HEEDLS-526 Fix incorrect back links, update titles on RegisterAdmin p…
8617098 
…ages
@ibrahimmunir14
HEEDLS-526 Use email from model, not data, for validation
b359703
davidm-m
davidm-m reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@davidm-m davidm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I've got a couple of small suggestions and it would be great if you could check over all the changed files to make sure they're in UTF-8 with BOM encoding.

davidm-m
davidm-m approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@davidm-m davidm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

stellake
stellake reviewed Jun 28, 2021
View reviewed changes
@ibrahimmunir14
HEEDLS-526 Extract T&Cs form group into view component
1deb1b6
@ibrahimmunir14
HEEDLS-526 Add type to PersonalInformation vc-text-inputs; fix page t…
b733e35 
…itle
@ibrahimmunir14
Merge branch 'master' into HEEDLS-526-admin-registration-frontend
896f801
@ibrahimmunir14
HEEDLS-526 Add NavMenuItems to AdminReg views; fix layout/spacing to …
ea89b87 
…match normal registration
@ibrahimmunir14
HEEDLS-526 Use virtual & override SetLearnerInformation instead of de…
379c104 
…claring new in subclass
@ibrahimmunir14
HEEDLS-526 Rename helper methods in RegisterAdminController
56a9aaf
@ibrahimmunir14
HEEDLS-526 Add RegistrationData constructor accepting a centreId
24ee69c
@ibrahimmunir14
HEEDLS-526 Create Controllers/Register folder; minor cosmetic changes
e9063fa
@ibrahimmunir14
HEEDLS-526 Move register mapping helpers into viewmodel constructors;…
cc09014 
… update controllers and tests
@ibrahimmunir14
HEEDLS-526 Refactor registration data mapping helper tests
82105de
@ibrahimmunir14 ibrahimmunir14 requested a review from stellake June 29, 2021 10:15
stellake
stellake approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a minor comment about syntax, but no need for re-review. Also looks like there are minor conflicts (presumably because of the centre ranking page change in centre data service - should be trivial to resolve) 👍

@ibrahimmunir14 ibrahimmunir14 force-pushed the HEEDLS-526-admin-registration-frontend branch from 66a384f to 4ed693b Compare June 29, 2021 12:32
@ibrahimmunir14 ibrahimmunir14 merged commit fb651e6 into master Jun 29, 2021
@stellake stellake deleted the HEEDLS-526-admin-registration-frontend branch July 1, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@davidm-m davidm-m davidm-m approved these changes

@stellake stellake stellake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibrahimmunir14 @davidm-m @stellake