Skip to content

HEEDLS-429 Notification preferences endpoints case insensitivity #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2021
Merged

HEEDLS-429 Notification preferences endpoints case insensitivity #458

merged 1 commit into from
Jul 1, 2021

Conversation

@ibrahimmunir14
Copy link
Contributor

@ibrahimmunir14 ibrahimmunir14 commented Jun 30, 2021 •
edited
Loading

  • Add flag to ignore case in TryGetFromIdOrName method in Enumeration
  • Ignore case when matching with enumerations in model binder

@ibrahimmunir14 ibrahimmunir14 changed the title HEEDLS-429 Notification preferences endpoints case insensitive HEEDLS-429 Notification preferences endpoints case insensitivity Jun 30, 2021
AlexJacksonDS
AlexJacksonDS approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, I assume you checked it works for the example that I gave that failed testing?

@ibrahimmunir14
Copy link
Contributor Author

Looks OK, I assume you checked it works for the example that I gave that failed testing?

Yep.

stellake
stellake approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ibrahimmunir14 ibrahimmunir14 merged commit 4fa512b into master Jul 1, 2021
@stellake stellake deleted the HEEDLS-429-notification-preferences-endpoints--fix branch July 8, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stellake stellake stellake approved these changes

@AlexJacksonDS AlexJacksonDS AlexJacksonDS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibrahimmunir14 @stellake @AlexJacksonDS