Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

Changed all usages of word-break: break-word to word-break: break-all

IE screens the ticket was raised for:
image

image

@AlexJacksonDS
Copy link
Contributor Author

I've added the IE only fix using the same pattern we use elsewhere in the css.

Since there was only one instance of each of the other css classes with word-break being used, I've instead added the .word-break css class to the html elements and removed it from the specific css classes so that we don't have to define the IE fix multiple times.

.nhsuk-summary-list__value {
@include govuk-media-query($until: tablet) {
word-break: break-word;
word-break: break-all;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - forgot to change here. Also, does the hack work ok on other main browsers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this adds an extra declaration for IE only, other browsers only see break-word. IE gets both and ignores the one it doesn't support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many instances of this to add a css class to each of them so I've defined it using a mixin instead

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - looks good! 👍

@AlexJacksonDS AlexJacksonDS merged commit 548dca4 into master Jul 2, 2021
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-542-fix-wrapping-in-IE branch July 2, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants