HEEDLS-490 All delegates - display delegate cards #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate empty page with delegates sidebar
…d to populate with additional info
|
Just had a quick scan to check the page structure was set up ready for future search etc. work which at first glance looks correct. @stellake The cards are using the NHS tags, that we decided on the Admin cards to not use in favour of the course card tags. They look quite nice but this page definitely should be consistent with the admins page as they are both in the tracking system which means one of us need to change them. I think consistency with course cards is less important. |
AlexJacksonDS
suggested changes
Jul 6, 2021
DigitalLearningSolutions.Web/Styles/trackingSystem/allDelegates.scss
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/Index.cshtml
Show resolved
Hide resolved
...ningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/_SearchableDelegateCard.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/Index.cshtml
Outdated
Show resolved
Hide resolved
...ningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/_SearchableDelegateCard.cshtml
Outdated
Show resolved
Hide resolved
...ningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/_SearchableDelegateCard.cshtml
Show resolved
Hide resolved
AlexJacksonDS
approved these changes
Jul 6, 2021
stellake
reviewed
Jul 6, 2021
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/AllDelegatesController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/Index.cshtml
Outdated
Show resolved
Hide resolved
...ningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/_SearchableDelegateCard.cshtml
Outdated
Show resolved
Hide resolved
...ningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/_SearchableDelegateCard.cshtml
Outdated
Show resolved
Hide resolved
...ningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/_SearchableDelegateCard.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ViewModels/TrackingSystem/Delegates/AllDelegatesViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/AllDelegates/Index.cshtml
Show resolved
Hide resolved
…apping in controller
…egates accessibility test
stellake
reviewed
Jul 7, 2021
...b.Tests/ViewModels/TrackingSystem/Delegates/AllDelegates/SearchableDelegateViewModelTests.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Jul 7, 2021
DigitalLearningSolutions.Data.Tests/DataServices/UserDataServiceTests.cs
Outdated
Show resolved
Hide resolved
stellake
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new page at
/TrackingSystem/Delegates/All, visible only to centre admins, to display delegate info cards. Currently displays first ten delegates only. Buttons don't do anything.Button group on mobile screen sizes:
