Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

Increased the spacing between the table and the no activity text on the admin table. Also added aria-current to the highlighted row (which I think is the right attribute?)

image

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I agree that aria-current should be used here. We've used it on the side nav menus and the home pages, so it should be good.

@AlexJacksonDS
Copy link
Contributor Author

image

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AlexJacksonDS AlexJacksonDS merged commit 9a0a7ed into master Jul 5, 2021
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-468-basic-centre-ranking-page branch July 5, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants