Skip to content

Conversation

@ibrahimmunir14
Copy link
Contributor

/TrackingSystem/Delegates/Register/PersonalInformation
localhost_44363_TrackingSystem_Delegates_Register_PersonalInformation

/TrackingSystem/Delegates/Register/LearnerInformation
localhost_44363_TrackingSystem_Delegates_Register_LearnerInformation

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, few minor comments about some refactoring.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few comments + it looks like the "Cancel" button spacing isn't consistent with the other pages 👍

@ibrahimmunir14 ibrahimmunir14 requested a review from stellake July 8, 2021 11:38
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ibrahimmunir14 ibrahimmunir14 merged commit 2ffaa9b into master Jul 8, 2021
@stellake stellake deleted the HEEDLS-545-all-delegates-register-1-2 branch July 8, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants