-
Notifications
You must be signed in to change notification settings - Fork 1
HEEDLS-545 All delegates - register delegate - Page 1,2 #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…earnerInformation pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, few minor comments about some refactoring.
DigitalLearningSolutions.Web/Views/RegisterDelegateByCentre/PersonalInformation.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/RegisterDelegateByCentre/PersonalInformation.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A few comments + it looks like the "Cancel" button spacing isn't consistent with the other pages 👍
DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/RegisterDelegateByCentre/PersonalInformation.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/Register/RegisterDelegateByCentreController.cs
Show resolved
Hide resolved
…PersonalInformation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
/TrackingSystem/Delegates/Register/PersonalInformation/TrackingSystem/Delegates/Register/LearnerInformation