Skip to content

HEEDLS-547 All delegates - register delegate - registration and confirmation #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 15, 2021
Merged

HEEDLS-547 All delegates - register delegate - registration and confirmation #491

merged 10 commits into from
Jul 15, 2021

Conversation

@ibrahimmunir14
Copy link
Contributor

Confirmation page (welcome email was SET)
localhost_44363_TrackingSystem_Delegates_Register_Confirmation

Confirmation page (welcome email was NOT SET, password was NOT SET)
localhost_44363_TrackingSystem_Delegates_Register_Confirmation (1)

Confirmation page (welcome email was NOT SET, password was SET)
localhost_44363_TrackingSystem_Delegates_Register_Confirmation (2)

stellake
stellake reviewed Jul 15, 2021
View reviewed changes
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we should write the Automated UI tests like for the normal delegate registration (but not save candidate). And it's worth writing a few controller tests around TempData. :)

stellake
stellake approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

stellake
stellake approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ibrahimmunir14 ibrahimmunir14 merged commit 59876d1 into master Jul 15, 2021
@stellake stellake deleted the HEEDLS-547-all-delegates-register-registration branch July 16, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stellake stellake stellake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ibrahimmunir14 @stellake