HEEDLS-431 - Populated course setup cards #492
Conversation
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/CourseSetup/SearchableCourseStatisticsViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Helpers/FilterOptions/CourseFilterOptions.cs
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/CourseSetup/SearchableCourseStatisticsViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/CourseSetup/_CentreCourseCard.cshtml
Outdated
Show resolved
Hide resolved
| <div class="nhsuk-grid-row"> | ||
| <div class="nhsuk-grid-column-full"> |
There was a problem hiding this comment.
Any reason we're adding new row/column elements for the "copy course" bit?
There was a problem hiding this comment.
This was to keep the Generate Email and Copy Course link on separate lines. Do we have an alternative preferred method for this?
There was a problem hiding this comment.
Isn't a button/p element on a new line automatically?
There was a problem hiding this comment.
Normally, yes, but when the button was present, it had the js-only-inline class which put everything inline. I've changed it to js-only-block, and removed the divs, and it achieves the same effect.
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Show resolved
Hide resolved
| </div> | ||
| <div class="nhsuk-grid-row"> | ||
| <div class="nhsuk-grid-column-full"> | ||
| <a href="#" class="js-only-inline copy-course-link nhsuk-link--no-visited-state" id="copy-course-@Model.CustomisationId">Copy course link</a> |
There was a problem hiding this comment.
Just wanted to double check if you've checked that this is the most appropriate HTML for this functionality (for clarity - I haven't looked into it at all)
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/trackingSystem/centreCourseSetup.ts
Outdated
Show resolved
Hide resolved
...ngSolutions.Web/ViewModels/TrackingSystem/CourseSetup/SearchableCourseStatisticsViewModel.cs
Show resolved
Hide resolved
| <div class="nhsuk-grid-row"> | ||
| <div class="nhsuk-grid-column-full"> |
There was a problem hiding this comment.
Isn't a button/p element on a new line automatically?
3 participants
Ran all unit tests. Tested in Chrome, Edge, Firefox, IE. Tested with screen reader, mobile view, and no JS.
Screen shots:
Desktop:
Mobile:
Desktop no JS:
