Skip to content

Conversation

@ibrahimmunir14
Copy link
Contributor

@ibrahimmunir14 ibrahimmunir14 commented Jul 15, 2021

Inactive user (laptop)

Active user (laptop)

Active user (tablet)

Active user (mobile)

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, main one would be about the use of SearchableDelegateViewModel.

…email is blank

To prevent the case where a centre has an admin with blank email, and any delegate at that centre with a blank email has a 'matching' email
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

… fields which may be null or empty

Also rename a test
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ibrahimmunir14 ibrahimmunir14 merged commit 5de19c8 into master Jul 19, 2021
@stellake stellake deleted the HEEDLS-554-view-delegate-page-delegate-info branch July 22, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants