-
Notifications
You must be signed in to change notification settings - Fork 1
HEEDLS-554 View delegate page - delegate info #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEEDLS-554 View delegate page - delegate info #493
Conversation
… delegate card Create ViewDelegate controller with delegateId parameter and required user policy; redirect to ViewDelegate index page from DelegateCard Manage Delegate button
…egateInfoVM tests; fix date string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, main one would be about the use of SearchableDelegateViewModel.
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ViewModels/TrackingSystem/Delegates/SearchableDelegateViewModel.cs
Show resolved
Hide resolved
…email is blank To prevent the case where a centre has an admin with blank email, and any delegate at that centre with a blank email has a 'matching' email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
DigitalLearningSolutions.Web/Styles/trackingSystem/viewDelegate.scss
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/DataServices/UserDataServiceTests.cs
Show resolved
Hide resolved
… minor formatting changes
…Cards; update tests; add accessibility test
DigitalLearningSolutions.Data.Tests/DataServices/UserDataServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
… fields which may be null or empty Also rename a test
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/ViewDelegate/Index.cshtml
Outdated
Show resolved
Hide resolved
…es across tracking system and my account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Inactive user (laptop)
Active user (laptop)
Active user (tablet)
Active user (mobile)