HEEDLS-548 Exclude centres from self registration #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexJacksonDS Thanks! I added a unit test, let me know if it looks okay. |
livzorn
force-pushed
the
HEEDLS-548-exclude-centres-self-registration
branch
from
9e30922 to
be7d3bf
Compare
stellake
reviewed
Jul 22, 2021
| @"SELECT CentreID, CentreName | ||
| FROM Centres | ||
| WHERE Active = 1 | ||
| AND kbSelfRegister = 1 |
There was a problem hiding this comment.
Happy to put this in the db query level given that this is only used in registration, but I think we should modify the name of the method so it's clear that we're getting the centre options for delegate self registration (rather than a true active centres list, which should technically only have the Active = 1 constraint)
There was a problem hiding this comment.
Good idea! I changed the method name to account for this
livzorn
force-pushed
the
HEEDLS-548-exclude-centres-self-registration
branch
from
be7d3bf to
994c16c
Compare
stellake
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix - I added one line to exclude centres with kbSelfRegister=0 from the select options in the delegate self-registration journey.