Heedls 557 email length consistency

[livzorn]

JIRA link

HEEDLS-557

Description

I created a migration that changed the maximum length of the Email column on AdminUsers table from 250 to 255 characters, so it is consistent with the Candidates table. The migration also deletes and recreates the AdminUsers_Email index accordingly as it depends the Email column.

I also modified two view models so the form input for Email will have the same max length.

I will document these changes in the release notes after merge!

[AlexJacksonDS]

The change itself looks fine, but question for @stellake.

I can see that you've decided the centre fields are out of scope for this ticket in the HLD discussion, but now we are in the situation where the Centre manager can have an email that is 255 in the AdminUsers table, but only 250 in the Centres table. Do we have a ticket in the future to fix this? (Centre website email is 100 characters too, but doesn't necessarily match an admin like the CentreManager field should)

[stellake]

I can see that you've decided the centre fields are out of scope for this ticket in the HLD discussion, but now we are in the situation where the Centre manager can have an email that is 255 in the AdminUsers table, but only 250 in the Centres table. Do we have a ticket in the future to fix this? (Centre website email is 100 characters too, but doesn't necessarily match an admin like the CentreManager field should)

The centre manager details are completely independent of the admin user that has centre manager permissions. The reason we're changing the email lengths of the users is that it affects the logins/core functionality/how we've combined these users into one account. The centre manager details are there as additional contact details display for centre, so we're good to leave it (and this way we don't need to introduce extra risk or spend unnecessary budget either). I suspect in reality, no one's going to specify their centre contact details as something with 200+ characters :)

[stellake]

Looks good! 👍