Skip to content

HEEDLS-431 - Changed javascript to copy text before alert and updated… #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2021
Merged

HEEDLS-431 - Changed javascript to copy text before alert and updated… #512

merged 4 commits into from
Jul 27, 2021

Conversation

@DanBloxham-sw
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw commented Jul 26, 2021 •
edited
Loading

… button styling

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-431

Description

The previous javascript copying functions only copied the text to clipboard after the alert was dismissed. I've updated it to be copied first. I've also updated the styling of the button to look the same as other links when focussed (which it previously didn't).

Screenshots

image

Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

livzorn
livzorn approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@livzorn livzorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stellake stellake merged commit da3fe6f into master Jul 27, 2021
@stellake stellake deleted the HEEDLS-431-CourseDetailsCopyLinkFix branch August 11, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stellake stellake stellake left review comments

@livzorn livzorn livzorn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanBloxham-sw @stellake @livzorn