HEEDLS-562 Add cancel link component and replace back links with it #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimmunir14
suggested changes
Jul 27, 2021
| <button class="nhsuk-button" type="submit">Save</button> | ||
| </form> | ||
| <vc:back-link asp-controller="RegisterDelegateByCentre" asp-action="@Model.PreviousAction" link-text="Go back" /> | ||
| <vc:cancel-link asp-controller="AllDelegates" asp-action="Index" /> |
There was a problem hiding this comment.
I think this was the only use of PreviousAction, could you remove it from the VM please if there are no other references to it.
Comment on lines
9
to
11
| left: -2px; /* 2 */ | ||
| position: absolute; | ||
| top: -1px; /* 3 */ |
There was a problem hiding this comment.
What do the comments mean?
There was a problem hiding this comment.
I'd just copied the style from the NHS css for the back link, it has a few comments to describe what they do (basically alignment of the svg)
ibrahimmunir14
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-562
Description
Added a new Cancel Link view component that is the same as the back link, but has a cross instead of the <. Replaced all instances of the Back link component with text Cancel with this component. Also replaced some "< Go back" back links in multi page form journeys with Back buttons.
Screenshots
A few examples. Styling should be the same across all of them
Developer checks
I have: