Skip to content

Heedls 513 group delegates #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 11, 2021
Merged

Heedls 513 group delegates #530

merged 9 commits into from
Aug 11, 2021

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Aug 3, 2021 •
edited
Loading

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-513

Description

Adds a new page to display all the delegates within a group as a paginated list of NHS expanders.

Screenshots

image
image
image

Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@AlexJacksonDS
Copy link
Contributor Author

I've thought of something extra that I think should be implemented here that isn't explicitly stated on the ticket while doing HEEDLS-516 (the group courses counterpart of this page).

As is, you can currently access any group if you know the ID regardless of centre. I'm going to add a check that returns a not found if the GroupID is not for the correct centre.

This wasn't necessary for the old system as it wasn't a separate page, so it might have been missed during the scoping phase. It would be reasonably easy to bring that into this MR if we want, but will leave it for now.

SteveJacksonSoft
SteveJacksonSoft suggested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been picky. Sorry some of the comments are fairly blunt - my communication skills are lacking today. Read'em with a smile.

SteveJacksonSoft
SteveJacksonSoft reviewed Aug 6, 2021
View reviewed changes
@SteveJacksonSoft
Copy link
Contributor

I'm off on Monday, so I'll move this over to TL review.

JBsoftwire
JBsoftwire reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@JBsoftwire JBsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor questions.

DigitalLearningSolutions.Data/DataServices/GroupsDataService.cs Outdated
return connection.Query<GroupDelegate>(
@"SELECT
GroupDelegateID,
GroupID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, but is there a reason these are indented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, they aren't for me in visual studio.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just try re-indenting them, see if it fixes it.

DigitalLearningSolutions.Data/DataServices/GroupsDataService.cs Outdated
{
return connection.Query<string>(
@"SELECT
GroupLabel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more trivial, but that this indentation is inconsistent with (most of) the above is distracting me.

...Web.Tests/ViewModels/TrackingSystem/Delegates/DelegateGroups/GroupDelegatesViewModelTests.cs
1,
"Group name",
groupDelegates,
1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I don't properly understand this, but the test name claims it is defaulting to returning the first page, but this looks like an explicit request for the first page.

@AlexJacksonDS AlexJacksonDS merged commit e274e8b into master Aug 11, 2021
@stellake stellake deleted the HEEDLS-513-group-delegates branch August 11, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SteveJacksonSoft SteveJacksonSoft SteveJacksonSoft approved these changes

@JBsoftwire JBsoftwire JBsoftwire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexJacksonDS @SteveJacksonSoft @JBsoftwire