Skip to content

HEEDLS-506 Add word break to the delegate groups cards #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

HEEDLS-506 Add word break to the delegate groups cards #535

merged 1 commit into from
Aug 11, 2021

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Aug 10, 2021 •
edited
Loading

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-506

Description

Add word break css to the delegate group cards to fix long names breaking the layout

Screenshots

image
image

Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

stellake
stellake approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@AlexJacksonDS AlexJacksonDS merged commit 3a2add1 into master Aug 11, 2021
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-506-delegate-groups-basic-page branch August 11, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stellake stellake stellake approved these changes

@ibrahimmunir14 ibrahimmunir14 ibrahimmunir14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexJacksonDS @stellake @ibrahimmunir14