HEEDLS-495 All delegates - send single welcome email #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently without an actual working link to set password
And fix incorrect tag-text bug!
JBsoftwire
suggested changes
Aug 12, 2021
DigitalLearningSolutions.Web/Controllers/SetPasswordController.cs
Outdated
Show resolved
Hide resolved
JBsoftwire
approved these changes
Aug 13, 2021
stellake
reviewed
Aug 16, 2021
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/ViewDelegateController.cs
Outdated
Show resolved
Hide resolved
| <p>Dear {firstName},</p> | ||
| <p>An administrator has registered your details to give you access to the Digital Learning Solutions (DLS) platform under the centre {centreName}.</p> | ||
| <p>You have been assigned the unique DLS delegate number {candidateNumber}.</p> | ||
| <p>To complete your registration and access your Digital Learning Solutions content, please follow this link: <a href=""{setPasswordUrl}"">{setPasswordUrl}</a></p> |
There was a problem hiding this comment.
How does this hyperlink read out with a screen reader? Would it be better to name it something more clear like "Click here to complete your registration..."
We have a little bit of wiggle room to change things here to be more accessible :)
DigitalLearningSolutions.Data.Tests/Services/RegistrationServiceTests.cs
Show resolved
Hide resolved
stellake
reviewed
Aug 17, 2021
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/ViewDelegateController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/ViewDelegateController.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/SetPasswordControllerBase.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/SetPasswordControllerBase.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/SetPasswordController.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Aug 18, 2021
| namespace DigitalLearningSolutions.Web.Helpers | ||
| { | ||
| using System; | ||
| using System.Drawing; |
There was a problem hiding this comment.
I keep getting these caused by resharper thinking it knows better, in this case it was Icon instead of IConfiguration i think, and the cleanup code doesn't reliably remove unused usings.
stellake
reviewed
Aug 18, 2021
| .With(rp => rp.PasswordResetDateTime = createTime).Build(); | ||
|
|
||
| // When | ||
| var resetIsValid = resetPassword.IsStillValidAt(createTime + TimeSpan.FromMinutes(4319), ResetPasswordHelpers.SetPasswordHasExpiryTime); |
There was a problem hiding this comment.
"HasExpiryTime" is missing a "h"
stellake
approved these changes
Aug 18, 2021
AlexJacksonDS
deleted the
HEEDLS-495-all-delegates-single-welcome-email
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
HEEDLS-495
Description
When the “Send welcome email” button is clicked on “Manage delegate” page, we send the delegate a welcome email including a link to set their password. The Set Password logic and pages are heavily based on, in fact, almost identical to, Reset Password.
Screenshots
Welcome Email
Welcome email sent page
Set Password page
Password set page
Developer checks
I have: