Skip to content

Conversation

@ibrahimmunir14
Copy link
Contributor

JIRA link

HEEDLS-497

Description

Set default welcome email date to today's date (and should send by default).
Update DateValidator to accept today's date (previously only accepted dates in the future).
Modify relevant accessibility test to ignore the axe violation caused by aria-expanded on #ShouldSendEmail (nhs-tested component).

Screenshots

No visible frontend changes to see.


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Ignore axe violation caused by aria-expanded on nhs-tested component
Copy link
Contributor

@livzorn livzorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@DanBloxham-sw DanBloxham-sw merged commit c1e3cfe into master Aug 18, 2021
@DanBloxham-sw DanBloxham-sw deleted the HEEDLS-497-all-delegates-register--welcome-email-change branch August 18, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants