HEEDLS-432 - Centre Course Setup search sort filter and paginate impl… #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
29
to
30
| ApplicationName = "Course", CustomisationName = "Customisation", Active = true, CourseTopic = "Topic 1", | ||
| CategoryName = "Category 1", HideInLearnerPortal = true, DelegateCount = 1, CompletedCount = 1 |
There was a problem hiding this comment.
This initialiser shouldn't be formatted like this
| private readonly ICourseService courseService; | ||
|
|
||
| public CourseSetupController(ICourseService courseService) | ||
| public CourseSetupController(ICourseService courseService, ICourseCategoriesDataService courseCategoriesDataService, ICourseTopicsDataService courseTopicsDataService) |
There was a problem hiding this comment.
Long line, run formatter
| return View(model); | ||
| } | ||
|
|
||
| private void UpdateFilterCookie(string? filterBy) |
There was a problem hiding this comment.
I took a slightly different approach to this comment and only took out the contents of the true branch to a new method. We should be consistent, but I'm not sure which way.
If we take the approach here, the method needs renaming to something referencing the fact that it may also be deleted here.
AlexJacksonDS
approved these changes
Aug 19, 2021
stellake
reviewed
Aug 23, 2021
DigitalLearningSolutions.Data/DataServices/CourseTopicsDataService.cs
Outdated
Show resolved
Hide resolved
...ningSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseSetupControllerTests.cs
Outdated
Show resolved
Hide resolved
...lLearningSolutions.Web/ViewModels/TrackingSystem/CourseSetup/AllCourseStatisticsViewModel.cs
Outdated
Show resolved
Hide resolved
...lLearningSolutions.Web/ViewModels/TrackingSystem/CourseSetup/AllCourseStatisticsViewModel.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ViewModels/TrackingSystem/CourseSetup/CourseSetupViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/CourseSetup/Index.cshtml
Show resolved
Hide resolved
stellake
reviewed
Aug 24, 2021
...olutions.Web/ViewModels/TrackingSystem/CourseSetup/CourseStatisticsViewModelFilterOptions.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Aug 24, 2021
DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/CourseSetupController.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Aug 24, 2021
...ningSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseSetupControllerTests.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Aug 24, 2021
...ningSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseSetupControllerTests.cs
Outdated
Show resolved
Hide resolved
stellake
reviewed
Aug 24, 2021
...ningSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseSetupControllerTests.cs
Outdated
Show resolved
Hide resolved
stellake
approved these changes
Aug 24, 2021
DanBloxham-sw
deleted the
HEEDLS-432-CentreCourseSetupSearchAndPagination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...emented
JIRA link
This is split over three tickets:
Search & Paginate: https://softwiretech.atlassian.net/browse/HEEDLS-432
Sort: https://softwiretech.atlassian.net/browse/HEEDLS-433
Filter: https://softwiretech.atlassian.net/browse/HEEDLS-434
Description
Implemented both JS and non-JS versions of searching, pagination, sorting, and filtering to the Course Setup page.
Screenshots
JS UI with full page:
Non JS UI:
Mobile:
Developer checks
I have: