Skip to content

Conversation

@ibrahimmunir14
Copy link
Contributor

JIRA link

HEEDLS-495

Description

  • Modify link in set password email
  • Address delegates by full name (firstname + lastname) in emails from tracking system, even if firstname is null

Screenshots

image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@ibrahimmunir14 ibrahimmunir14 changed the title Heedls 495 - All delegates - single welcome email fix HEEDLS-495 - All delegates - single welcome email fix Aug 26, 2021
Copy link
Contributor

@JBsoftwire JBsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming that User.cs is just line ending changes.

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just double check the line endings before merge 👍

@ibrahimmunir14 ibrahimmunir14 merged commit e184950 into master Aug 27, 2021
@stellake stellake deleted the HEEDLS-495-all-delegates-single-welcome-email--fix branch September 3, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants