Skip to content

Conversation

@ibrahimmunir14
Copy link
Contributor

JIRA link

HEEDLS-505

Description

  • Add further validation and error messages:
    • Length checks for FirstName, LastName, AliasId, Email, Answer1-6
    • Email format check
  • Identical to validation in normal registration, except Email maxlength here is 250 instead of 255 to match the stored procedure.

Screenshots

N/A


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a comment about where to store the strings, but no need for rereview :)

BulkUploadResult.ErrorReason.AliasIdInUse => "The Alias ID is already in use by another delegate.",
BulkUploadResult.ErrorReason.EmailAddressInUse =>
"The Email address is already in use by another delegate.",
BulkUploadResult.ErrorReason.TooLongFirstName => "First name must be 250 characters or fewer.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if some of these strings should be in the CommonValidationErrorMessages

@ibrahimmunir14 ibrahimmunir14 force-pushed the HEEDLS-505-all-delegates-bulk-upload-journey--validation branch from 29a853b to 7ea3b30 Compare September 13, 2021 09:49
@ibrahimmunir14 ibrahimmunir14 merged commit c36c13f into master Sep 13, 2021
@stellake stellake deleted the HEEDLS-505-all-delegates-bulk-upload-journey--validation branch September 14, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants