- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Heedls 441 edit course content #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of questions and a bunch of changes I think would be good
        
          
                DigitalLearningSolutions.Data/DataServices/ProgressDataService.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/DataServices/SectionContentDataService.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/DataServices/TutorialContentDataService.cs
          
            Show resolved
            Hide resolved
        
              
          
                ...alLearningSolutions.Data.Tests/DataServices/TutorialContentDataServiceTests/TutorialTests.cs
          
            Show resolved
            Hide resolved
        
              
          
                ...alLearningSolutions.Data.Tests/DataServices/TutorialContentDataServiceTests/TutorialTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/Services/SectionServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...ngSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseContentControllerTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...ngSolutions.Web.Tests/Controllers/TrackingSystem/CourseSetup/CourseContentControllerTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of mostly minor changes that can probably be argued against. But also one question about the ticket and it's implementation.
There is a small thing at the end of the ticket description that looks like it wasn't fully written:
Note that a tutorial can only have Diagnostic enabled (often used by centres to test what the delegates already know without necessarily forcing them to go through the learning content),
which seems to suggest that there might be some limits as to whether diagnostic can be enabled, but doesn't state the limits. I can't see any docs that mention this, and can't remember anything about it when I did the Course Content Index page. Don't suppose you know what it implies?
        
          
                ...ingSolutions.Web.Tests/ViewModels/TrackingSystem/CourseSetup/CourseTutorialViewModelTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/CourseContentController.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Styles/trackingSystem/courseContent.scss
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...tions.Web/ViewModels/TrackingSystem/CourseSetup/CourseContent/EditCourseTutorialViewModel.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...lutions.Web/ViewModels/TrackingSystem/CourseSetup/CourseContent/EditCourseSectionFormData.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/DataServices/ProgressDataService.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/TestHelpers/TutorialContentTestHelper.cs
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/DataServices/ProgressDataServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...alLearningSolutions.Data.Tests/DataServices/TutorialContentDataServiceTests/TutorialTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...alLearningSolutions.Data.Tests/DataServices/TutorialContentDataServiceTests/TutorialTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor things on the new additions and a couple of things from before remain unresolved as I don't think they've been tackled yet.
As for the other potentially mis-typed comment, I'm not too convinced as it still doesn't make much sense to me with the assumed corrections. But if this works the same as the old site I think that satisfies me.

JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-441
Description
Removes the Edit Course Content button from the bottom of the view course content page, and replaces it with edit section buttons in each expandable.
New page to edit the Learning/Diagnostic statuses for each tutorial in a section for a course.
Minor refactoring of the javascript used for the select all buttons on the Email delegates page to commonise code.
Screenshots
Developer checks
I have: