Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Sep 24, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-441

Description

Removes the Edit Course Content button from the bottom of the view course content page, and replaces it with edit section buttons in each expandable.
New page to edit the Learning/Diagnostic statuses for each tutorial in a section for a course.
Minor refactoring of the javascript used for the select all buttons on the Email delegates page to commonise code.

Screenshots

image
image
image


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@davidm-m davidm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of questions and a bunch of changes I think would be good

Copy link
Contributor

@davidm-m davidm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of mostly minor changes that can probably be argued against. But also one question about the ticket and it's implementation.

There is a small thing at the end of the ticket description that looks like it wasn't fully written:

Note that a tutorial can only have Diagnostic enabled (often used by centres to test what the delegates already know without necessarily forcing them to go through the learning content),

which seems to suggest that there might be some limits as to whether diagnostic can be enabled, but doesn't state the limits. I can't see any docs that mention this, and can't remember anything about it when I did the Course Content Index page. Don't suppose you know what it implies?

@AlexJacksonDS
Copy link
Contributor Author

Note that a tutorial can only have Diagnostic enabled (often used by centres to test what the delegates already know without necessarily forcing them to go through the learning content),

I interpreted this as just a mistyping, "can have only Diagnostic". The old system allows you to freely select any
image

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things on the new additions and a couple of things from before remain unresolved as I don't think they've been tackled yet.

As for the other potentially mis-typed comment, I'm not too convinced as it still doesn't make much sense to me with the assumed corrections. But if this works the same as the old site I think that satisfies me.

@AlexJacksonDS AlexJacksonDS merged commit 1bcc723 into master Oct 13, 2021
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-441-edit-course-content branch October 13, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants