- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Heedls 496 promote delegate to admin #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question about one part of this, for which the answer may be 'no' in which case we can move it on.
        
          
                DigitalLearningSolutions.Web/ViewModels/Common/AdminRolesViewModel.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I think could use improving, the might be good reasons for them though - feel free to argue with me

JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-496
Description
Added a new Promote Delegate to Admin page accessed from the View Delegate page.
The button to access this page on the View delegate page is now only visible to Centre Manager/Super Admins
Refactored the RegisterDataService/RegistrationModels so that there isn't unnecessary duplication and properties are on the correct models (e.g. no more JobGroup on the model used to register admins)
This ticket also includes some changes made by Steve for 602 that weren't quite compatible with the data service at the time that were then reverted (535b1b5)
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: