Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Sep 30, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-496

Description

Added a new Promote Delegate to Admin page accessed from the View Delegate page.
The button to access this page on the View delegate page is now only visible to Centre Manager/Super Admins
Refactored the RegisterDataService/RegistrationModels so that there isn't unnecessary duplication and properties are on the correct models (e.g. no more JobGroup on the model used to register admins)
This ticket also includes some changes made by Steve for 602 that weren't quite compatible with the data service at the time that were then reverted (535b1b5)

Screenshots

image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@JBsoftwire JBsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about one part of this, for which the answer may be 'no' in which case we can move it on.

Copy link
Contributor

@davidm-m davidm-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I think could use improving, the might be good reasons for them though - feel free to argue with me

@AlexJacksonDS
Copy link
Contributor Author

Screenshot of email in use page
image

@AlexJacksonDS AlexJacksonDS merged commit cc6808e into master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants