Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Oct 1, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-613

Description

Converted the Change Password and Edit Details pages to the new inheritance Form Data setup from the Form Data property setup.
Removed the new versions of the input view components that were necessary with the form data property change, and removed the obsolete marking from the old versions of the view components.
Documentation of the design decision here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/19806453895/View+Models+and+Form+Data

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, merge away.

@AlexJacksonDS AlexJacksonDS merged commit a5a44f6 into master Oct 11, 2021
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-613-form-data-inheritance branch October 11, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants