Skip to content

Conversation

@showkath10
Copy link
Contributor

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-629

Description

Added new text as per wireframe,
Updated exiting text
Removed LoginCount=0 when removing progress records since the progress records can be deleted where course is started but not competed.

Screenshots

image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • [] Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • [] Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • [x ] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • [x ] Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes on the page styling, and a potentially more significant change for the data service method.

Also you are going to want to merge master into this branch so that the accessibility tests pass on Jenkins.

@DanBloxham-sw
Copy link
Contributor

Actually, I've realised the controller needs changes as well. Judging from the wording of the ticket, and the wording on the page, we should be calling that dataservice method when the second checkbox is unchecked as well. It is just when the checkbox is checked, then we should no longer care about the login count.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, just a few minor things.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick renaming that I've spotted, but it should be good after that.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge.

@showkath10 showkath10 merged commit b7c1b8a into master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants